[Doc] Fix review comments on precheck-pr skill
- Fix NPU skill name in readme to match declared name - Fix base-branch detection to use explicit fallback - Fix title format reference to point to docs/contributing/README.md - Move /precheck-pr prompt to top of PR template Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: hsliu <liuhongsheng4@huawei.com>
This commit is contained in:
1 parent
975d79e44b
commit
fb472ecfc7
4 files changed
+7
-8
No files matched your search
@@ -22,11 +22,10 @@ Default to quick if unsure. Run full before marking a PR "ready for review."
|
||||
|
||||
```bash
|
||||
BASE=$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main 2>/dev/null)
|
||||
BASE=${BASE:-main}
|
||||
git diff --name-only ${BASE}...HEAD
|
||||
```
|
||||
|
||||
If no base is found, use `main`.
|
||||
|
||||
### Step 2: Validate PR Title
|
||||
|
||||
Check the most recent commit message (or branch name if no commit yet) against the project convention. Valid prefixes:
|
||||
|
||||
@@ -6,7 +6,7 @@ Each item is a concrete check to run against the diff. ✗ = fix before PR. ⚠
|
||||
|
||||
## All PRs: Title Format (check first)
|
||||
|
||||
PR title must follow the project convention documented in CLAUDE.md:
|
||||
PR title must follow the project convention documented in `docs/contributing/README.md`:
|
||||
|
||||
| Prefix | Applies to |
|
||||
|--------|-----------|
|
||||
|
||||
@@ -26,8 +26,8 @@ include:
|
||||
format, catches dead code, verifies accuracy/perf claims, and confirms merge
|
||||
readiness
|
||||
- `review-pr`: provides a structured workflow for reviewing pull requests
|
||||
- `vllm-omni-npu-upgrade`: upgrades NPU model runners to align with the latest
|
||||
vllm-ascend NPUModelRunner
|
||||
- `vllm-omni-npu-model-runner-upgrade`: upgrades NPU model runners to align with the
|
||||
latest vllm-ascend NPUModelRunner
|
||||
|
||||
## Maintenance Guidelines
|
||||
|
||||
|
||||
@@ -1,4 +1,6 @@
|
||||
<!-- markdownlint-disable -->
|
||||
**Before submitting:** run `/precheck-pr` in Claude Code for a self-check against project conventions — catches dead code, missing benchmarks, and title format issues.
|
||||
|
||||
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
|
||||
|
||||
## Purpose
|
||||
@@ -18,7 +20,5 @@ PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTT
|
||||
- [ ] (Optional) Release notes update. If your change is user-facing, please update the release notes draft.
|
||||
</details>
|
||||
|
||||
**BEFORE SUBMITTING:**
|
||||
- Run `/precheck-pr` in Claude Code for a self-check against project conventions — catches dead code, missing benchmarks, and title format issues.
|
||||
- Please read <https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md>
|
||||
**BEFORE SUBMITTING,** please read <https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md>
|
||||
(anything written below this line will be removed by GitHub Actions)
|
||||
Reference in new issue
Block a user