From fb472ecfc7752b66125bab9f36015727252d5c0a Mon Sep 17 00:00:00 2001 From: hsliu Date: Sat, 6 Jun 2026 22:36:19 +0800 Subject: [PATCH] [Doc] Fix review comments on precheck-pr skill - Fix NPU skill name in readme to match declared name - Fix base-branch detection to use explicit fallback - Fix title format reference to point to docs/contributing/README.md - Move /precheck-pr prompt to top of PR template Co-Authored-By: Claude Opus 4.7 Signed-off-by: hsliu --- .claude/skills/precheck-pr/SKILL.md | 3 +-- .claude/skills/precheck-pr/references/checklists.md | 2 +- .claude/skills/readme.md | 4 ++-- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.claude/skills/precheck-pr/SKILL.md b/.claude/skills/precheck-pr/SKILL.md index 5387fe2a1..229be23cd 100644 --- a/.claude/skills/precheck-pr/SKILL.md +++ b/.claude/skills/precheck-pr/SKILL.md @@ -22,11 +22,10 @@ Default to quick if unsure. Run full before marking a PR "ready for review." ```bash BASE=$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main 2>/dev/null) +BASE=${BASE:-main} git diff --name-only ${BASE}...HEAD ``` -If no base is found, use `main`. - ### Step 2: Validate PR Title Check the most recent commit message (or branch name if no commit yet) against the project convention. Valid prefixes: diff --git a/.claude/skills/precheck-pr/references/checklists.md b/.claude/skills/precheck-pr/references/checklists.md index f4ce1214a..5518d702d 100644 --- a/.claude/skills/precheck-pr/references/checklists.md +++ b/.claude/skills/precheck-pr/references/checklists.md @@ -6,7 +6,7 @@ Each item is a concrete check to run against the diff. ✗ = fix before PR. ⚠ ## All PRs: Title Format (check first) -PR title must follow the project convention documented in CLAUDE.md: +PR title must follow the project convention documented in `docs/contributing/README.md`: | Prefix | Applies to | |--------|-----------| diff --git a/.claude/skills/readme.md b/.claude/skills/readme.md index 8ce03c840..d64c2738b 100644 --- a/.claude/skills/readme.md +++ b/.claude/skills/readme.md @@ -26,8 +26,8 @@ include: format, catches dead code, verifies accuracy/perf claims, and confirms merge readiness - `review-pr`: provides a structured workflow for reviewing pull requests -- `vllm-omni-npu-upgrade`: upgrades NPU model runners to align with the latest - vllm-ascend NPUModelRunner +- `vllm-omni-npu-model-runner-upgrade`: upgrades NPU model runners to align with the + latest vllm-ascend NPUModelRunner ## Maintenance Guidelines diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f2890c094..25a844cb2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,6 @@ +**Before submitting:** run `/precheck-pr` in Claude Code for a self-check against project conventions — catches dead code, missing benchmarks, and title format issues. + PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED. ## Purpose @@ -18,7 +20,5 @@ PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTT - [ ] (Optional) Release notes update. If your change is user-facing, please update the release notes draft. -**BEFORE SUBMITTING:** -- Run `/precheck-pr` in Claude Code for a self-check against project conventions — catches dead code, missing benchmarks, and title format issues. -- Please read +**BEFORE SUBMITTING,** please read (anything written below this line will be removed by GitHub Actions)