Address code review feedback

- Remove unused `field` import
- Move `json` import to top of file
- Add comment explaining local DiffusionParallelConfig import

Co-authored-by: hsliuustc0106 <222337142+hsliuustc0106@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]andhsliuustc0106 committed 2026-01-18 14:22:03 +00:00
1 parent 294625f67d
commit c5f5fe4221
1 file changed
+3 -3
+3 -3
View File
@@ -6,7 +6,8 @@ This module provides a robust, type-safe approach to building stage configuratio
programmatically, replacing ad-hoc dictionary construction.
"""
from dataclasses import dataclass, field
import json
from dataclasses import dataclass
from typing import Any
from omegaconf import DictConfig, OmegaConf
@@ -144,8 +145,6 @@ class StageConfigFactory:
Returns:
Normalized cache configuration dictionary or None
"""
import json
if isinstance(cache_config, str):
try:
cache_config = json.loads(cache_config)
@@ -234,6 +233,7 @@ class StageConfigFactory:
Returns:
List containing a single dict for the diffusion stage (not wrapped in OmegaConf)
"""
# Local import to avoid potential circular dependencies with diffusion module
from vllm_omni.diffusion.data import DiffusionParallelConfig
# Normalize cache configuration