From c5f5fe4221ddf13c9babe6e394908ee9cdf84aca Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 18 Jan 2026 14:22:03 +0000
Subject: [PATCH] Address code review feedback

- Remove unused `field` import
- Move `json` import to top of file
- Add comment explaining local DiffusionParallelConfig import

Co-authored-by: hsliuustc0106 <222337142+hsliuustc0106@users.noreply.github.com>
---
 vllm_omni/entrypoints/stage_config.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vllm_omni/entrypoints/stage_config.py b/vllm_omni/entrypoints/stage_config.py
index 4764d2998..c08906388 100644
--- a/vllm_omni/entrypoints/stage_config.py
+++ b/vllm_omni/entrypoints/stage_config.py
@@ -6,7 +6,8 @@ This module provides a robust, type-safe approach to building stage configuratio
 programmatically, replacing ad-hoc dictionary construction.
 """
 
-from dataclasses import dataclass, field
+import json
+from dataclasses import dataclass
 from typing import Any
 
 from omegaconf import DictConfig, OmegaConf
@@ -144,8 +145,6 @@ class StageConfigFactory:
         Returns:
             Normalized cache configuration dictionary or None
         """
-        import json
-        
         if isinstance(cache_config, str):
             try:
                 cache_config = json.loads(cache_config)
@@ -234,6 +233,7 @@ class StageConfigFactory:
         Returns:
             List containing a single dict for the diffusion stage (not wrapped in OmegaConf)
         """
+        # Local import to avoid potential circular dependencies with diffusion module
         from vllm_omni.diffusion.data import DiffusionParallelConfig
         
         # Normalize cache configuration