Merge pull request 'Show Reviewer named skill set in README' (#7) from ISSUE-6 into main

Reviewed-on: #1

NOTICE.md

@@ -2,13 +2,12 @@
 
 The instruction packages and authoring tools in this repository are licensed under the MIT License in [LICENSE](LICENSE). Include that license and copyright notice when redistributing a package or fork.
 
-The optional role guidance is newly written for RelayView from the owner's personal skill collection. Several source skills trace to Matt Pocock's skills at revision `c55ee46073ed923f86ce59a5eb3b6d895095d1b7`; the `c4-diff` source skill traces to Jo Van Eyck's skills at revision `f2de8f7042a5125116ed27627fc7320b73048469`. Their MIT copyright and permission notices are preserved below. No plugin text, code, or assets are redistributed. This release has no third-party runtime dependencies or vendored executable assets. Python's standard library runs the authoring checks and is not bundled into a skill package.
+The RelayView owner, its private prompts, and its separate open trust modules are outside this repository and its MIT grant.
+
+The optional role guidance is written for RelayView from the owner's personal skill collection. Several source skills trace to Matt Pocock's skills at revision `c55ee46073ed923f86ce59a5eb3b6d895095d1b7`; the `c4-diff` source skill traces to Jo Van Eyck's skills at revision `f2de8f7042a5125116ed27627fc7320b73048469`. Their MIT copyright and permission notices are preserved below. No plugin text, code, or assets are redistributed. This release has no third-party runtime dependencies or vendored executable assets. Python's standard library runs the authoring checks and is not bundled into a skill package.
 
 ## Matt Pocock source-skill notice
 
-
-
-The RelayView owner, its private prompts, and its separate open trust modules are outside this repository and its MIT grant.
 MIT License
 
 Copyright (c) 2026 Matt Pocock

README.md

@@ -22,7 +22,8 @@ Public source for RelayView-maintained instruction-only role skills and an illus
 | `packages/scaffold-exercises` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/shared-abstraction-refactor` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/split-large-files` | Optional guidance | Implementer / implementation | 0.3.0 |
-| `packages/tdd` | Optional guidance | Implementer / implementation | 0.3.0 |
+| `packages/tdd` | Optional manual guidance | Implementer / implementation | 0.3.0 |
+| `packages/tdd-auto` | Optional automatic guidance | Implementer / implementation | 0.3.1 |
 | `packages/writing-for-agents` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/code-review` | Optional guidance | Reviewer / review | 0.3.0 |
 | `packages/c4-diff` | Optional guidance | Reviewer / review | 0.3.0 |
@@ -30,6 +31,25 @@ Public source for RelayView-maintained instruction-only role skills and an illus
 
 Only named releases of maintained packages receive RelayView compatibility testing and maintenance. Optional guidance requires explicit role assignment; the two original defaults remain available. User forks are maintained by their publishers. This release uses the instruction package schema version 1 admitted by RelayView's Community MVP. It contains only `SKILL.md`, declared `.md`/`.txt` resources, and `relayview-skill.json` within each package. Scripts, executable files, undeclared files, and requested permissions fail checks and owner admission. There is no fixed release calendar: maintained packages are versioned when their content or compatibility changes. A breaking owner contract requires a new compatible maintained release before the product depends on it.
 
+## A named set in RelayView
+
+A named set groups admitted packages for one role and workflow step. In **Settings → Skills**, the Reviewer has **Reviewer inspection on request** selected as its manual set. Its saved and effective choices match, so future Reviewer sessions capture these two skills for manual invocation. The automatic selector remains at its configured default, which is empty in this example.
+
+![RelayView Settings Skills Reviewer card with the manual set Reviewer inspection on request saved and effective, containing Code review followed by Component diff](docs/images/reviewer-manual-skill-set.png)
+
+The screenshot's ordered manual members come from this excerpt under `trustedSkills.sets` in the owner configuration. Both member IDs must also be admitted in `trustedSkills.catalog`; defining a set makes it available, while selecting and saving it makes it effective for future sessions.
+
+```yaml
+- id: reviewer-inspection
+  name: Reviewer inspection on request
+  role: reviewer
+  step: review
+  invocationMode: manual
+  members: [code-review, c4-diff]
+```
+
+The two maintained defaults are original RelayView packages. Some optional guidance adapts earlier MIT-licensed skills; see the [third-party notices](NOTICE.md).
+
 ## Fork the starter
 
 Clone this repository, copy `examples/starter-planner` to a new directory named for your skill, and edit its `SKILL.md` and `local-guidance.md`. Set the frontmatter `name` to the directory name and give it a distinct version. Keep `source.kind` as `user` and set `source.reference` to your fork's release identifier. Update each `files[].sha256` with the SHA-256 of the exact file bytes. Then run:
@@ -42,7 +62,7 @@ python -m tools.packages pack examples/starter-planner dist/starter-planner.zip
 
 Replace `examples/starter-planner` in the last two commands with your package directory. The `pack` command writes a reproducible ZIP containing the package, `LICENSE`, and `NOTICE.md`, then prints its SHA-256. The check returns the owner's package identity digest. Both use only Python 3's standard library and this repository's source. Preserve the license and notice when redistributing the package or fork.
 
-To import a user fork, place its closed package directory under the owner's configured trusted root, use Settings → Skills to import the relative `SKILL.md` path under a new unique ID, and assign it to the matching future role step. Saving a new assignment takes effect after owner restart; existing sessions retain their captured bytes. The Settings catalog displays source, version, digest, role, step, and pending versus effective assignment. The owner's admission remains authoritative even when these local checks pass.
+To use a user fork, place its closed package directory under the owner's configured trusted root and use Settings → Skills to import the relative `SKILL.md` path under a new unique ID. Import validates and records the package; it does not assign it. Add that ID to a role-compatible named set in the owner configuration and restart the owner to load the set. Then select the set for the matching role in Settings → Skills and save. That selection takes effect for future sessions immediately; existing sessions retain their captured bytes. The Settings catalog displays source, version, digest, role, step, and pending versus effective assignment. The owner's admission remains authoritative even when these local checks pass.
 
 To use a maintained default, copy its release package under the same trusted root, admit its `SKILL.md` through the owner catalog, then select it for its declared role in Settings. Settings import accepts user-source packages; configure first-party packages in the owner catalog. Select a fork with `source.kind: user` and a distinct ID to replace that role's future assignment. Planner guidance uses existing read and planning tools; Implementer guidance uses existing implementation and reporting tools. Neither selection changes a role's tools, credentials, lifecycle stages, validation requirements, Gitea effects, review, merge, or Human acceptance. The owner keeps the existing Gitea task workflow.
 

packages/tdd-auto/SKILL.md

@@ -0,0 +1,13 @@
+---
+name: tdd-auto
+description: Test-driven development for an assigned implementation Plan; use red, green, and focused verification at its agreed test seams.
+metadata:
+  relayview-display-name: Test-driven development
+  relayview-version: 0.3.1
+---
+
+# Test-driven development
+
+Use the test seams and behavior specified by the immutable Plan. Read the target repository's domain language and test conventions. If the Plan leaves a consequential seam unclear, report that gap to the owner; do not create a new acceptance boundary by silently choosing one.
+
+At each seam, write one test that fails for the missing behavior and observe the failure. Implement the smallest production slice that makes it pass. Repeat for the next behavior, then run the focused checks required by the Plan. Assert observable behavior through public interfaces, using expected values independent of the implementation. Avoid private-method assertions, tautological expectations, and a batch of tests for behavior not yet explored. Record the red and green evidence in the implementation handoff.

packages/tdd-auto/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.3.1"
+  },
+  "role": "implementer",
+  "step": "implementation",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "cf4f0cd039dc283caabc3238e3d084c2d59a3f8c8ba030595e9ea80e2b1338e6"
+    }
+  ]
+}

tests/test_packages.py

@@ -12,6 +12,18 @@ ROOT = Path(__file__).resolve().parents[1]
 
 
 class PackageTests(unittest.TestCase):
+    def test_tdd_is_available_to_owner_started_implementers(self):
+        package = ROOT / "packages/tdd-auto"
+        skill = (package / "SKILL.md").read_text()
+        frontmatter = skill.split("---", 2)[1]
+        self.assertIn("name: tdd-auto", frontmatter)
+        self.assertNotIn("disable-model-invocation: true", frontmatter)
+        self.assertIn("relayview-version: 0.3.1", frontmatter)
+        manifest = json.loads((package / "relayview-skill.json").read_text())
+        self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.3.1"})
+        check_package(package)
+        self.assertIn("disable-model-invocation: true", (ROOT / "packages/tdd/SKILL.md").read_text())
+
     def test_migrated_role_guidance_has_one_declared_role_step(self):
         expected = {"codebase-design": ("planner", "planning"), "grill-me": ("planner", "planning"),
                     "grilling": ("planner", "planning"), "to-questionnaire": ("planner", "planning"),