Merge pull request 'Add Issue Designer instruction packages' (#9) from ISSUE-949 into main

Reviewed-on: #1

NOTICE.md

@@ -2,13 +2,12 @@
 
 The instruction packages and authoring tools in this repository are licensed under the MIT License in [LICENSE](LICENSE). Include that license and copyright notice when redistributing a package or fork.
 
-The optional role guidance is newly written for RelayView from the owner's personal skill collection. Several source skills trace to Matt Pocock's skills at revision `c55ee46073ed923f86ce59a5eb3b6d895095d1b7`; the `c4-diff` source skill traces to Jo Van Eyck's skills at revision `f2de8f7042a5125116ed27627fc7320b73048469`. Their MIT copyright and permission notices are preserved below. No plugin text, code, or assets are redistributed. This release has no third-party runtime dependencies or vendored executable assets. Python's standard library runs the authoring checks and is not bundled into a skill package.
+The RelayView owner, its private prompts, and its separate open trust modules are outside this repository and its MIT grant.
+
+The optional role guidance is written for RelayView from the owner's personal skill collection. Several source skills trace to Matt Pocock's skills at revision `c55ee46073ed923f86ce59a5eb3b6d895095d1b7`; the `c4-diff` source skill traces to Jo Van Eyck's skills at revision `f2de8f7042a5125116ed27627fc7320b73048469`. Their MIT copyright and permission notices are preserved below. No plugin text, code, or assets are redistributed. This release has no third-party runtime dependencies or vendored executable assets. Python's standard library runs the authoring checks and is not bundled into a skill package.
 
 ## Matt Pocock source-skill notice
 
-
-
-The RelayView owner, its private prompts, and its separate open trust modules are outside this repository and its MIT grant.
 MIT License
 
 Copyright (c) 2026 Matt Pocock

README.md

@@ -8,6 +8,10 @@ Public source for RelayView-maintained instruction-only role skills and an illus
 | --- | --- | --- | --- |
 | `packages/planner-scope` | Maintained default | Planner / planning | 0.2.0 |
 | `packages/implementer-handoff` | Maintained default | Implementer / implementation | 0.2.0 |
+| `packages/issue-designer-default` | Maintained default | Designer / design | 0.6.0 |
+| `packages/designer-wayfinder`, `designer-grilling`, `designer-prototype` | Optional manual guidance | Designer / design | 0.6.0 |
+| `packages/designer-research`, `designer-domain-modeling`, `designer-triage` | Optional manual guidance | Designer / design | 0.6.0 |
+| `packages/designer-to-spec`, `designer-to-tickets` | Optional manual guidance | Designer / design | 0.6.0 |
 | `packages/codebase-design` | Optional guidance | Planner / planning | 0.3.0 |
 | `packages/grill-me` | Optional guidance | Planner / planning | 0.3.0 |
 | `packages/grilling` | Optional guidance | Planner / planning | 0.3.0 |
@@ -22,13 +26,33 @@ Public source for RelayView-maintained instruction-only role skills and an illus
 | `packages/scaffold-exercises` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/shared-abstraction-refactor` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/split-large-files` | Optional guidance | Implementer / implementation | 0.3.0 |
-| `packages/tdd` | Optional guidance | Implementer / implementation | 0.3.0 |
+| `packages/tdd` | Optional manual guidance | Implementer / implementation | 0.3.0 |
+| `packages/tdd-auto` | Optional automatic guidance | Implementer / implementation | 0.3.1 |
 | `packages/writing-for-agents` | Optional guidance | Implementer / implementation | 0.3.0 |
 | `packages/code-review` | Optional guidance | Reviewer / review | 0.3.0 |
 | `packages/c4-diff` | Optional guidance | Reviewer / review | 0.3.0 |
 | `examples/starter-planner` | Illustrative starter; not a production default | Planner / planning | 0.1.0 |
 
-Only named releases of maintained packages receive RelayView compatibility testing and maintenance. Optional guidance requires explicit role assignment; the two original defaults remain available. User forks are maintained by their publishers. This release uses the instruction package schema version 1 admitted by RelayView's Community MVP. It contains only `SKILL.md`, declared `.md`/`.txt` resources, and `relayview-skill.json` within each package. Scripts, executable files, undeclared files, and requested permissions fail checks and owner admission. There is no fixed release calendar: maintained packages are versioned when their content or compatibility changes. A breaking owner contract requires a new compatible maintained release before the product depends on it.
+Only named releases of maintained packages receive RelayView compatibility testing and maintenance. Optional guidance requires explicit role assignment; the Planner and Implementer defaults remain available alongside the pinned Issue Designer default. User forks are maintained by their publishers. This release uses the instruction package schema version 1 admitted by RelayView's Community MVP. It contains only `SKILL.md`, declared `.md`/`.txt` resources, and `relayview-skill.json` within each package. Scripts, executable files, undeclared files, and requested permissions fail checks and owner admission. There is no fixed release calendar: maintained packages are versioned when their content or compatibility changes. A breaking owner contract requires a new compatible maintained release before the product depends on it.
+
+## A named set in RelayView
+
+A named set groups admitted packages for one role and workflow step. In **Settings → Skills**, the Reviewer has **Reviewer inspection on request** selected as its manual set. Its saved and effective choices match, so future Reviewer sessions capture these two skills for manual invocation. The automatic selector remains at its configured default, which is empty in this example.
+
+![RelayView Settings Skills Reviewer card with the manual set Reviewer inspection on request saved and effective, containing Code review followed by Component diff](docs/images/reviewer-manual-skill-set.png)
+
+The screenshot's ordered manual members come from this excerpt under `trustedSkills.sets` in the owner configuration. Both member IDs must also be admitted in `trustedSkills.catalog`; defining a set makes it available, while selecting and saving it makes it effective for future sessions.
+
+```yaml
+- id: reviewer-inspection
+  name: Reviewer inspection on request
+  role: reviewer
+  step: review
+  invocationMode: manual
+  members: [code-review, c4-diff]
+```
+
+The maintained defaults are original RelayView packages. Some optional guidance adapts earlier MIT-licensed skills; see the [third-party notices](NOTICE.md).
 
 ## Fork the starter
 
@@ -42,9 +66,9 @@ python -m tools.packages pack examples/starter-planner dist/starter-planner.zip
 
 Replace `examples/starter-planner` in the last two commands with your package directory. The `pack` command writes a reproducible ZIP containing the package, `LICENSE`, and `NOTICE.md`, then prints its SHA-256. The check returns the owner's package identity digest. Both use only Python 3's standard library and this repository's source. Preserve the license and notice when redistributing the package or fork.
 
-To import a user fork, place its closed package directory under the owner's configured trusted root, use Settings → Skills to import the relative `SKILL.md` path under a new unique ID, and assign it to the matching future role step. Saving a new assignment takes effect after owner restart; existing sessions retain their captured bytes. The Settings catalog displays source, version, digest, role, step, and pending versus effective assignment. The owner's admission remains authoritative even when these local checks pass.
+To use a user fork, place its closed package directory under the owner's configured trusted root. For Planner, Implementer, or Reviewer guidance, use Settings → Skills to import the relative `SKILL.md` path under a new unique ID. Import validates and records the package; it does not assign it. Add that ID to a role-compatible named set in the owner configuration and restart the owner to load the set. Then select the set for the matching role in Settings → Skills and save. For an optional Designer method, declare its ID and relative `SKILL.md` path in `trustedSkills.catalog`, list the ID in `workflowPresets.designerSkills`, and restart the owner. Designer has no Settings import or set selector for this assignment. These assignments affect future sessions; existing sessions retain their captured bytes. The owner's admission remains authoritative even when these local checks pass.
 
-To use a maintained default, copy its release package under the same trusted root, admit its `SKILL.md` through the owner catalog, then select it for its declared role in Settings. Settings import accepts user-source packages; configure first-party packages in the owner catalog. Select a fork with `source.kind: user` and a distinct ID to replace that role's future assignment. Planner guidance uses existing read and planning tools; Implementer guidance uses existing implementation and reporting tools. Neither selection changes a role's tools, credentials, lifecycle stages, validation requirements, Gitea effects, review, merge, or Human acceptance. The owner keeps the existing Gitea task workflow.
+To use a maintained Planner or Implementer default, copy its release package under the same trusted root, admit its `SKILL.md` through the owner catalog, then select it for its declared role in Settings. Settings import accepts user-source packages; configure first-party packages in the owner catalog. Select a fork with `source.kind: user` and a distinct ID to replace a Planner or Implementer future assignment. RelayView pins and assigns the Issue Designer default automatically; its optional methods use `workflowPresets.designerSkills`. Planner guidance uses existing read and planning tools; Implementer guidance uses existing implementation and reporting tools. Guidance selection does not change a role's tools, credentials, lifecycle stages, validation requirements, Gitea effects, review, merge, or Human acceptance. The owner keeps the existing Gitea task workflow.
 
 ## Release identity
 

packages/designer-domain-modeling/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-domain-modeling
+description: Sharpen project terms, invariants, and boundaries for an issue draft.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer domain modeling
+  relayview-version: 0.6.0
+---
+
+# Domain modeling
+
+Read the assigned project's current context and relevant authoritative contracts. Name concepts in the project's own vocabulary; identify identities, state transitions, invariants, and boundaries that the proposed work touches. Ask the Human when a term or invariant changes acceptance. Put the resulting definitions and open choices in the draft without claiming a repository document was edited.

packages/designer-domain-modeling/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "cfb72adc02cf0a488c341d965c16e22d22e90c52ab0540a9072b09c592d1abd7"
+    }
+  ]
+}

packages/designer-grilling/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-grilling
+description: Stress test one proposed issue design through focused Human questions.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer grilling
+  relayview-version: 0.6.0
+---
+
+# Grilling
+
+State the design and scope to be challenged and seek the Human's agreement before entering this method. Probe one consequential assumption at a time: behavior, boundary, dependency, failure, or verification. Use each answer to choose the next question. Stop when the important branches are resolved or explicitly left open; summarize the agreed design and open decisions in the draft.

packages/designer-grilling/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "431da86a21da7b74fa55bce36c1e0fc806d066cd8b1ace7a784e1eb4a2db4a89"
+    }
+  ]
+}

packages/designer-prototype/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-prototype
+description: Plan a bounded throwaway prototype to answer a design question.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer prototype
+  relayview-version: 0.6.0
+---
+
+# Prototype
+
+Propose the exact question, bounded code or data scope, expected preview or data effects, and limits to the Human before entering this method. Use only owner-admitted prototype controls after agreement. Treat observations as evidence about the question, not production behavior. Record what was tried, observed, and still uncertain; keep throwaway changes out of the issue's implementation claim.

packages/designer-prototype/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "3898ccf2566614ac3fc54afadd857ebd1e61701d0fe1344b92f79f6b01278706"
+    }
+  ]
+}

packages/designer-research/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-research
+description: Research a design question using admitted repository, tracker, and public sources.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer research
+  relayview-version: 0.6.0
+---
+
+# Research
+
+Frame the question and the decision it informs. Prefer current primary sources and the assigned repository's authoritative documents. Use only the owner's assigned repository, tracker, and brokered public research tools and active request budget. For each conclusion, keep source, observation time, and completeness visible. Distinguish a source statement from your inference and record material gaps in the draft.

packages/designer-research/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "676c4291d4bab19c76c0d945eefe21aa6787783e4e2d2285e0d6e270303d1e94"
+    }
+  ]
+}

packages/designer-to-spec/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-to-spec
+description: Turn an agreed problem into a complete reviewable issue specification.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer to spec
+  relayview-version: 0.6.0
+---
+
+# To spec
+
+Use the agreed problem and observed project contracts to draft an outcome, scope boundaries, acceptance observations, failure and recovery behavior, and open decisions. Check prerequisites against the assigned tracker and mark uncertain links as proposed. Save the complete text through the owner-stored draft. The Human decides readiness and publication.

packages/designer-to-spec/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "c4b8707f88faf1b9f3e04bb707b45bbb3d89848a8a3b2ac807dc819e8dd29f91"
+    }
+  ]
+}

packages/designer-to-tickets/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-to-tickets
+description: Decompose an agreed specification into ordered issue proposals.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer to tickets
+  relayview-version: 0.6.0
+---
+
+# To tickets
+
+Choose independently reviewable slices with observable outcomes and prerequisite edges only where one slice truly requires another. For each proposed issue, state scope, acceptance, verification, and context a cold-start agent needs. Present the ordered set and relationship rationale to the Human. Keep proposals private until Human review and owner publication.

packages/designer-to-tickets/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "561db3543cfdffe55b8002954d7debcf9d0fc1125d51c688a74cf2469d3d73a1"
+    }
+  ]
+}

packages/designer-triage/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-triage
+description: Classify and route an observed issue before drafting work.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer triage
+  relayview-version: 0.6.0
+---
+
+# Triage
+
+Observe the current report and related tracker state. Separate verified symptoms, missing information, proposed behavior, and duplicate or prerequisite work. Suggest the smallest useful next state and explain the evidence for it. Draft an issue or question for Human review; only owner controls can change tracker status or placement.

packages/designer-triage/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "fa62a0806921d87ddd27e494cfc379513cc147ad658eb5a2981970ccb25babf5"
+    }
+  ]
+}

packages/designer-wayfinder/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: designer-wayfinder
+description: Map an uncertain design decision into options and a Human choice.
+disable-model-invocation: true
+metadata:
+  relayview-display-name: Designer Wayfinder
+  relayview-version: 0.6.0
+---
+
+# Wayfinder
+
+Use this method for a decision whose alternatives materially change the work. First describe the decision, why it matters, and the bounded scope to the Human; enter the method only after the Human agrees. Observe current facts, list viable options with consequences and reversibility, and ask the smallest question that separates them. Record the Human's decision and remaining uncertainty in the owner-stored draft when relevant. This is decision work, not a ready implementation claim.

packages/designer-wayfinder/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "c5b5db0755af497cfe9be9fee9912f1406fb3b8546d7f389998516ba298f27b0"
+    }
+  ]
+}

packages/issue-designer-default/SKILL.md

@@ -0,0 +1,15 @@
+---
+name: issue-designer-default
+description: Guide ordinary Issue Designer Chats from observed facts to a reviewable draft.
+metadata:
+  relayview-display-name: Issue Designer default
+  relayview-version: 0.6.0
+---
+
+# Issue Designer default
+
+Check current facts before drafting. Read the assigned repository's relevant authoritative documentation, code, tests, and tracker observations; state the source, observation time, and any incomplete read. Keep proposed behavior separate from verified current behavior.
+
+Choose the scale with the Human: one issue for bounded work, an ordered issue set for dependent work, or a narrower question when the outcome is unclear. Ask only for decisions that change scope, acceptance, or authority. A useful draft states the problem, observable outcome, boundaries, prerequisites, and verification including failure behavior. Preserve unresolved choices explicitly.
+
+Use the owner-stored draft for the current issue. Before calling it ready, check that a new agent can start from the draft and available repository context without this Chat: dependencies and acceptance observations are named, assumptions are visible, and the proposed readiness matches the remaining uncertainty. The Human reviews and publishes through owner controls.

packages/issue-designer-default/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.6.0"
+  },
+  "role": "designer",
+  "step": "design",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "5e5b407b8390edc24f365e509e1da607bdbed918ffed07f4b2c03eb6bc0d8e80"
+    }
+  ]
+}

packages/tdd-auto/SKILL.md

@@ -0,0 +1,13 @@
+---
+name: tdd-auto
+description: Test-driven development for an assigned implementation Plan; use red, green, and focused verification at its agreed test seams.
+metadata:
+  relayview-display-name: Test-driven development
+  relayview-version: 0.3.1
+---
+
+# Test-driven development
+
+Use the test seams and behavior specified by the immutable Plan. Read the target repository's domain language and test conventions. If the Plan leaves a consequential seam unclear, report that gap to the owner; do not create a new acceptance boundary by silently choosing one.
+
+At each seam, write one test that fails for the missing behavior and observe the failure. Implement the smallest production slice that makes it pass. Repeat for the next behavior, then run the focused checks required by the Plan. Assert observable behavior through public interfaces, using expected values independent of the implementation. Avoid private-method assertions, tautological expectations, and a batch of tests for behavior not yet explored. Record the red and green evidence in the implementation handoff.

packages/tdd-auto/relayview-skill.json

@@ -0,0 +1,15 @@
+{
+  "schemaVersion": 1,
+  "source": {
+    "kind": "first-party",
+    "reference": "v0.3.1"
+  },
+  "role": "implementer",
+  "step": "implementation",
+  "files": [
+    {
+      "path": "SKILL.md",
+      "sha256": "cf4f0cd039dc283caabc3238e3d084c2d59a3f8c8ba030595e9ea80e2b1338e6"
+    }
+  ]
+}

tests/test_packages.py

@@ -12,6 +12,36 @@ ROOT = Path(__file__).resolve().parents[1]
 
 
 class PackageTests(unittest.TestCase):
+    def test_designer_release_modes_and_source(self):
+        automatic = "issue-designer-default"
+        manual = (
+            "designer-wayfinder", "designer-grilling", "designer-prototype",
+            "designer-research", "designer-domain-modeling", "designer-triage",
+            "designer-to-spec", "designer-to-tickets",
+        )
+        for name in (automatic, *manual):
+            with self.subTest(name=name):
+                package = ROOT / "packages" / name
+                skill = (package / "SKILL.md").read_text()
+                frontmatter = skill.split("---", 2)[1]
+                self.assertEqual("disable-model-invocation: true" in frontmatter, name in manual)
+                self.assertIn("relayview-version: 0.6.0", frontmatter)
+                manifest = json.loads((package / "relayview-skill.json").read_text())
+                self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.6.0"})
+                check_package(package)
+
+    def test_tdd_is_available_to_owner_started_implementers(self):
+        package = ROOT / "packages/tdd-auto"
+        skill = (package / "SKILL.md").read_text()
+        frontmatter = skill.split("---", 2)[1]
+        self.assertIn("name: tdd-auto", frontmatter)
+        self.assertNotIn("disable-model-invocation: true", frontmatter)
+        self.assertIn("relayview-version: 0.3.1", frontmatter)
+        manifest = json.loads((package / "relayview-skill.json").read_text())
+        self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.3.1"})
+        check_package(package)
+        self.assertIn("disable-model-invocation: true", (ROOT / "packages/tdd/SKILL.md").read_text())
+
     def test_migrated_role_guidance_has_one_declared_role_step(self):
         expected = {"codebase-design": ("planner", "planning"), "grill-me": ("planner", "planning"),
                     "grilling": ("planner", "planning"), "to-questionnaire": ("planner", "planning"),
@@ -27,7 +57,11 @@ class PackageTests(unittest.TestCase):
                     "code-review": ("reviewer", "review"),
                     "c4-diff": ("reviewer", "review"),
                     "research": ("planner", "planning"),
-                    "improve-codebase-architecture": ("planner", "planning")}
+                    "improve-codebase-architecture": ("planner", "planning"),
+                    **{name: ("designer", "design") for name in (
+                        "issue-designer-default", "designer-wayfinder", "designer-grilling", "designer-prototype",
+                        "designer-research", "designer-domain-modeling", "designer-triage",
+                        "designer-to-spec", "designer-to-tickets")}}
         for name, role_step in expected.items():
             with self.subTest(name=name):
                 package = ROOT / "packages" / name

tools/packages.py

@@ -51,7 +51,7 @@ def check_package(path):
         _fail(f"{path}: invalid source")
     if source["kind"] not in ("first-party", "user") or not isinstance(source["reference"], str) or not re.fullmatch(r"[A-Za-z0-9._:-]{1,128}", source["reference"]):
         _fail(f"{path}: invalid source identity")
-    if manifest["schemaVersion"] != 1 or (manifest["role"], manifest["step"]) not in (("planner", "planning"), ("implementer", "implementation"), ("reviewer", "review")):
+    if manifest["schemaVersion"] != 1 or (manifest["role"], manifest["step"]) not in (("planner", "planning"), ("implementer", "implementation"), ("reviewer", "review"), ("designer", "design")):
         _fail(f"{path}: incompatible role or step")
     files = manifest["files"]
     if not isinstance(files, list) or not 1 <= len(files) <= 16: