Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6948a2670a | ||
|
|
1f6cce14a8 | ||
|
|
1756c46c06 | ||
|
|
74ace113f6 |
No files matched your search
@@ -87,3 +87,5 @@ Judge a change over several runs, using the tool calls each run made, not one su
|
|||||||
A release tag pins public source. CI runs package checks and archives from that source. RelayView's bundled copy records the source tag and commit plus each package identity and file hash, then verifies the bytes in its own focused test. A bundled update creates a new release identity; it does not overwrite a user fork.
|
A release tag pins public source. CI runs package checks and archives from that source. RelayView's bundled copy records the source tag and commit plus each package identity and file hash, then verifies the bytes in its own focused test. A bundled update creates a new release identity; it does not overwrite a user fork.
|
||||||
|
|
||||||
The MIT license covers this repository only. The contribution policy is in [CONTRIBUTING.md](CONTRIBUTING.md); dependency notices are in [NOTICE.md](NOTICE.md).
|
The MIT license covers this repository only. The contribution policy is in [CONTRIBUTING.md](CONTRIBUTING.md); dependency notices are in [NOTICE.md](NOTICE.md).
|
||||||
|
|
||||||
|
The automatic `code-review-auto` package supplies optional bounded, path-aware finding presentation. Broader two-axis standards/spec inspection remains in the manual `code-review` package. Both use only the assigned Reviewer capabilities; required adequacy, disposition and recovery stay with the owner.
|
||||||
@@ -0,0 +1,11 @@
|
|||||||
|
---
|
||||||
|
name: code-review-auto
|
||||||
|
description: Present findings for the owner-assigned review candidate.
|
||||||
|
metadata:
|
||||||
|
relayview-display-name: Review finding presentation
|
||||||
|
relayview-version: 0.10.0
|
||||||
|
---
|
||||||
|
|
||||||
|
# Review finding presentation
|
||||||
|
|
||||||
|
Keep findings bounded, path-aware, and actionable.
|
||||||
@@ -0,0 +1,15 @@
|
|||||||
|
{
|
||||||
|
"schemaVersion": 1,
|
||||||
|
"source": {
|
||||||
|
"kind": "first-party",
|
||||||
|
"reference": "v0.10.0"
|
||||||
|
},
|
||||||
|
"role": "reviewer",
|
||||||
|
"step": "review",
|
||||||
|
"files": [
|
||||||
|
{
|
||||||
|
"path": "SKILL.md",
|
||||||
|
"sha256": "5a09004af9e208a80712dba2dad2975fcd457f296472f8cd2e13f48b43d0950d"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
@@ -4,7 +4,7 @@ description: Review the owner-pinned candidate against repository standards and
|
|||||||
disable-model-invocation: true
|
disable-model-invocation: true
|
||||||
metadata:
|
metadata:
|
||||||
relayview-display-name: Code review
|
relayview-display-name: Code review
|
||||||
relayview-version: 0.3.0
|
relayview-version: 0.10.0
|
||||||
---
|
---
|
||||||
|
|
||||||
# Two-axis code review
|
# Two-axis code review
|
||||||
@@ -12,3 +12,5 @@ metadata:
|
|||||||
Review only the candidate and commit identity supplied by the owner. Keep standards and Plan fidelity separate. For standards, cite the exact repository rule and changed hunk; identify possible design smells as judgment calls, never as rule violations. A documented local standard takes precedence over a general heuristic. For Plan fidelity, identify missing or partial requirements, unrequested behavior, and behavior whose implementation contradicts the accepted Plan. Cite the Plan clause and code evidence for each finding.
|
Review only the candidate and commit identity supplied by the owner. Keep standards and Plan fidelity separate. For standards, cite the exact repository rule and changed hunk; identify possible design smells as judgment calls, never as rule violations. A documented local standard takes precedence over a general heuristic. For Plan fidelity, identify missing or partial requirements, unrequested behavior, and behavior whose implementation contradicts the accepted Plan. Cite the Plan clause and code evidence for each finding.
|
||||||
|
|
||||||
Report both axes even if one has no findings. Distinguish evidence, inference, and uncertainty; skip issues already enforced by tooling unless the enforcement itself failed. Do not edit the candidate, create subagents, choose a new base, change the acceptance state, or request a new review run. The owner controls review scheduling, exact-head binding, and the response to findings.
|
Report both axes even if one has no findings. Distinguish evidence, inference, and uncertainty; skip issues already enforced by tooling unless the enforcement itself failed. Do not edit the candidate, create subagents, choose a new base, change the acceptance state, or request a new review run. The owner controls review scheduling, exact-head binding, and the response to findings.
|
||||||
|
|
||||||
|
Keep findings bounded, path-aware, and actionable.
|
||||||
@@ -2,14 +2,14 @@
|
|||||||
"schemaVersion": 1,
|
"schemaVersion": 1,
|
||||||
"source": {
|
"source": {
|
||||||
"kind": "first-party",
|
"kind": "first-party",
|
||||||
"reference": "v0.3.0"
|
"reference": "v0.10.0"
|
||||||
},
|
},
|
||||||
"role": "reviewer",
|
"role": "reviewer",
|
||||||
"step": "review",
|
"step": "review",
|
||||||
"files": [
|
"files": [
|
||||||
{
|
{
|
||||||
"path": "SKILL.md",
|
"path": "SKILL.md",
|
||||||
"sha256": "c2b05163e738e59573b96f723d5340f56304299bcdf251e38b2d2afb4eda2b5a"
|
"sha256": "bb7e5e4d30dcf43eddb9e16ddf7e7ddad123fba18ef7b22286b8b1233888b81b"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
@@ -12,6 +12,14 @@ ROOT = Path(__file__).resolve().parents[1]
|
|||||||
|
|
||||||
|
|
||||||
class PackageTests(unittest.TestCase):
|
class PackageTests(unittest.TestCase):
|
||||||
|
def test_automatic_review_is_only_extracted_presentation(self):
|
||||||
|
package = ROOT / "packages/code-review-auto"
|
||||||
|
check_package(package)
|
||||||
|
text = (package / "SKILL.md").read_text()
|
||||||
|
self.assertIn("path-aware, and actionable", text)
|
||||||
|
self.assertNotIn("Report both axes", text)
|
||||||
|
self.assertNotIn("subagent", text)
|
||||||
|
|
||||||
def test_handoff_clarification_method(self):
|
def test_handoff_clarification_method(self):
|
||||||
package = ROOT / "packages/implementer-handoff"
|
package = ROOT / "packages/implementer-handoff"
|
||||||
check_package(package)
|
check_package(package)
|
||||||
@@ -143,7 +151,7 @@ class PackageTests(unittest.TestCase):
|
|||||||
package = ROOT / "packages" / name
|
package = ROOT / "packages" / name
|
||||||
manifest = json.loads((package / "relayview-skill.json").read_text())
|
manifest = json.loads((package / "relayview-skill.json").read_text())
|
||||||
self.assertEqual((manifest["role"], manifest["step"]), (role, step))
|
self.assertEqual((manifest["role"], manifest["step"]), (role, step))
|
||||||
self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.8.1" if name == "planner-scope" else "v0.2.0"})
|
self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.8.1" if name == "planner-scope" else "v0.9.0"})
|
||||||
self.assertIn(resource, [item["path"] for item in manifest["files"]])
|
self.assertIn(resource, [item["path"] for item in manifest["files"]])
|
||||||
self.assertIn(marker, (package / "SKILL.md").read_text() + (package / resource).read_text())
|
self.assertIn(marker, (package / "SKILL.md").read_text() + (package / resource).read_text())
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user