Extract optional Reviewer finding presentation #15

Merged
anodyine merged 1 commits from ISSUE-1030 into main 2026-11-13 18:05:58 -05:00
Owner

Summary

Extract the existing automatic finding-presentation sentence into code-review-auto; extend the manual code-review method with that presentation advice. Publish immutable v0.10.0; prior releases stay unchanged.

Reviewer core -> mandatory judgment contract
code-review-auto -> optional finding presentation
code-review (manual) -> standards/spec techniques

Evidence

Before: the new package test failed with package must be a directory. After: all 18 Python package checks pass at 1f6cce14a8. RelayView public-source verification confirms v0.10.0 bytes and archive hashes.

Checks run

python3 -m unittest discover -s tests -v — 18 passed.

Documentation disposition

updated — README describes automatic versus manual scope.

Ablation decision

not_required — equivalent existing procedure extraction; owner review remains unchanged.

Merge Danger

Door: two-way for future selection; published v0.10.0 is immutable.

Blast Radius: optional Reviewer instruction packages. Roll back future selection to an earlier package; retain this tag for captured assignments.

Reviewer prerequisites

Python 3; no credentials or model calls for deterministic checks.

Manual Test Plan

No additional manual behavior: rerun the deterministic package suite from this checkout:

python3 -m unittest discover -s tests -v

Expected: all 18 tests pass. Stop on any package identity or authority failure; preserve output and correct source in a new release if published bytes need changing.

Post-Merge Cleanup

Keep v0.10.0 and the source branch until product review completes.

## Summary Extract the existing automatic finding-presentation sentence into `code-review-auto`; extend the manual `code-review` method with that presentation advice. Publish immutable v0.10.0; prior releases stay unchanged. ```text Reviewer core -> mandatory judgment contract code-review-auto -> optional finding presentation code-review (manual) -> standards/spec techniques ``` ## Evidence Before: the new package test failed with `package must be a directory`. After: all 18 Python package checks pass at 1f6cce14a864db8e3b2c9b9e1641774299b8d737. RelayView public-source verification confirms v0.10.0 bytes and archive hashes. ### Checks run `python3 -m unittest discover -s tests -v` — 18 passed. ## Documentation disposition updated — README describes automatic versus manual scope. ## Ablation decision not_required — equivalent existing procedure extraction; owner review remains unchanged. ## Merge Danger **Door:** two-way for future selection; published v0.10.0 is immutable. **Blast Radius:** optional Reviewer instruction packages. Roll back future selection to an earlier package; retain this tag for captured assignments. ## Reviewer prerequisites Python 3; no credentials or model calls for deterministic checks. ## Manual Test Plan No additional manual behavior: rerun the deterministic package suite from this checkout: ```sh python3 -m unittest discover -s tests -v ``` Expected: all 18 tests pass. Stop on any package identity or authority failure; preserve output and correct source in a new release if published bytes need changing. ## Post-Merge Cleanup Keep v0.10.0 and the source branch until product review completes.
anodyine added 1 commit 2026-11-13 17:32:22 -05:00
Extract optional automatic Reviewer finding presentation
Check instruction packages / check (push) Successful in 8s
Check instruction packages / check (pull_request) Successful in 4s
1f6cce14a8
Author
Owner

Reviewed source diff at 1f6cce14a8 against main: automatic package is limited to existing finding presentation; manual method retains standards/spec techniques; manifests match immutable release source. No actionable findings. Re-ran python3 -m unittest discover -s tests -v: 18 passed. Public release verification passed in product review. User authorized merge and cleanup.

Reviewed source diff at 1f6cce14a864db8e3b2c9b9e1641774299b8d737 against main: automatic package is limited to existing finding presentation; manual method retains standards/spec techniques; manifests match immutable release source. No actionable findings. Re-ran python3 -m unittest discover -s tests -v: 18 passed. Public release verification passed in product review. User authorized merge and cleanup.
anodyine merged commit 6948a2670a into main 2026-11-13 18:05:58 -05:00
anodyine deleted branch ISSUE-1030 2026-11-13 18:05:58 -05:00
Sign in to join this conversation.