[Misc] Cleanup: use consistent pytest-mock in unit tests (#2698)
Signed-off-by: yuanheng <jonathan.zhaoyh@gmail.com>
This commit is contained in:
1 parent
2c67c30550
commit
e0cdbe9a5d
26 files changed
+1598
-1369
No files matched your search
@@ -1,8 +1,7 @@
|
||||
"""Unit tests for OmniBase and AsyncOmni profiler methods."""
|
||||
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
from pytest_mock import MockerFixture
|
||||
|
||||
pytestmark = [pytest.mark.core_model, pytest.mark.cpu]
|
||||
|
||||
@@ -11,12 +10,12 @@ class TestOmniBaseProfiler:
|
||||
"""Test suite for OmniBase profiler methods (start_profile, stop_profile)."""
|
||||
|
||||
@pytest.fixture
|
||||
def mock_engine(self):
|
||||
def mock_engine(self, mocker: MockerFixture):
|
||||
"""Create a mock AsyncOmniEngine for testing."""
|
||||
engine = MagicMock()
|
||||
engine = mocker.MagicMock()
|
||||
engine.num_stages = 3
|
||||
engine.is_alive.return_value = True
|
||||
engine.default_sampling_params_list = [MagicMock() for _ in range(3)]
|
||||
engine.default_sampling_params_list = [mocker.MagicMock() for _ in range(3)]
|
||||
engine.get_stage_metadata.side_effect = lambda i: {
|
||||
"final_output_type": "text" if i == 0 else "audio",
|
||||
"final_output": True,
|
||||
@@ -25,17 +24,15 @@ class TestOmniBaseProfiler:
|
||||
return engine
|
||||
|
||||
@pytest.fixture
|
||||
def omni_base_instance(self, mock_engine):
|
||||
def omni_base_instance(self, mock_engine, mocker: MockerFixture):
|
||||
"""Create an OmniBase instance with mocked dependencies."""
|
||||
with (
|
||||
patch("vllm_omni.entrypoints.omni_base.AsyncOmniEngine", return_value=mock_engine),
|
||||
patch("vllm_omni.entrypoints.omni_base.omni_snapshot_download", side_effect=lambda x: x),
|
||||
patch("vllm_omni.entrypoints.omni_base.weakref.finalize"),
|
||||
):
|
||||
from vllm_omni.entrypoints.omni_base import OmniBase
|
||||
mocker.patch("vllm_omni.entrypoints.omni_base.AsyncOmniEngine", return_value=mock_engine)
|
||||
mocker.patch("vllm_omni.entrypoints.omni_base.omni_snapshot_download", side_effect=lambda x: x)
|
||||
mocker.patch("vllm_omni.entrypoints.omni_base.weakref.finalize")
|
||||
from vllm_omni.entrypoints.omni_base import OmniBase
|
||||
|
||||
instance = OmniBase(model="test-model")
|
||||
return instance
|
||||
instance = OmniBase(model="test-model")
|
||||
return instance
|
||||
|
||||
def test_start_profile_calls_collective_rpc(self, omni_base_instance, mock_engine):
|
||||
"""Test that start_profile calls collective_rpc with correct arguments."""
|
||||
|
||||
Reference in new issue
Block a user