From a3f2d4cbfe381dffc5a971c7398b4e9dab3032a1 Mon Sep 17 00:00:00 2001 From: Hongsheng Liu Date: Mon, 23 Feb 2026 07:52:09 +0800 Subject: [PATCH] Revert "[misc] Feature/pr reviewer auto trigger&update model" (#1432) --- .github/workflows/pr-reviewer.yml | 19 +++++++------------ vllm_omni/benchmarks/metrics/metrics.py | 4 ++-- vllm_omni/diffusion/envs.py | 2 +- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pr-reviewer.yml b/.github/workflows/pr-reviewer.yml index 5699e74c8..a503d3422 100644 --- a/.github/workflows/pr-reviewer.yml +++ b/.github/workflows/pr-reviewer.yml @@ -1,8 +1,6 @@ name: VLLM-Omni PR Reviewer on: - pull_request: - types: [opened, ready_for_review] issue_comment: types: [created] @@ -16,17 +14,14 @@ jobs: name: Review Pull Request runs-on: ubuntu-latest timeout-minutes: 10 - # Trigger on: - # 1. PR opened or marked ready for review (auto-run, only from same repo) - # 2. Manual @vllm-omni-reviewer comment by members/collaborators + # Only run when the comment is from a collaborator/owner/member if: | - (github.event_name == 'pull_request' && github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository) || - (github.event_name == 'issue_comment' && - github.event.issue.pull_request != null && - contains(github.event.comment.body, '@vllm-omni-reviewer') && - (github.event.comment.author_association == 'MEMBER' || - github.event.comment.author_association == 'COLLABORATOR' || - github.event.comment.author_association == 'OWNER')) + github.event_name == 'issue_comment' && + github.event.issue.pull_request != null && + contains(github.event.comment.body, '@vllm-omni-reviewer') && + (github.event.comment.author_association == 'MEMBER' || + github.event.comment.author_association == 'COLLABORATOR' || + github.event.comment.author_association == 'OWNER') steps: - name: Checkout repository uses: actions/checkout@v4.2.2 diff --git a/vllm_omni/benchmarks/metrics/metrics.py b/vllm_omni/benchmarks/metrics/metrics.py index 3258a4ad5..83671b713 100644 --- a/vllm_omni/benchmarks/metrics/metrics.py +++ b/vllm_omni/benchmarks/metrics/metrics.py @@ -223,8 +223,8 @@ def calculate_metrics( good_completed += 1 if completed == 0: - warnings.formatwarning = lambda msg, category, filename, lineno, line=None: ( - f"{filename}:{lineno}: {category.__name__}: {msg}\n" + warnings.formatwarning = ( + lambda msg, category, filename, lineno, line=None: f"{filename}:{lineno}: {category.__name__}: {msg}\n" ) warnings.warn( "All requests failed. This is likely due to a misconfiguration on the benchmark arguments.", diff --git a/vllm_omni/diffusion/envs.py b/vllm_omni/diffusion/envs.py index a71dc2e8e..dd566b059 100644 --- a/vllm_omni/diffusion/envs.py +++ b/vllm_omni/diffusion/envs.py @@ -20,7 +20,7 @@ environment_variables: dict[str, Callable[[], Any]] = { # used in distributed environment to determine the master address "MASTER_ADDR": lambda: os.getenv("MASTER_ADDR", ""), # used in distributed environment to manually set the communication port - "MASTER_PORT": lambda: int(os.getenv("MASTER_PORT", "0")) if "MASTER_PORT" in os.environ else None, + "MASTER_PORT": lambda: (int(os.getenv("MASTER_PORT", "0")) if "MASTER_PORT" in os.environ else None), # path to cudatoolkit home directory, under which should be bin, include, # and lib directories. "CUDA_HOME": lambda: os.environ.get("CUDA_HOME", None),