From 9454e7987c9c2ee2c4dd3ae6ddd356400ba693ca Mon Sep 17 00:00:00 2001 From: Hongsheng Liu Date: Thu, 1 Oct 2026 17:11:12 -0700 Subject: [PATCH] docs: distinguish generic review selection from session eligibility --- .../skills/review-pr/references/process/batch-review.md | 7 +++++++ .claude/skills/review-pr/tests/test_helpers.py | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.claude/skills/review-pr/references/process/batch-review.md b/.claude/skills/review-pr/references/process/batch-review.md index 660b90312..617cdf0b3 100644 --- a/.claude/skills/review-pr/references/process/batch-review.md +++ b/.claude/skills/review-pr/references/process/batch-review.md @@ -5,6 +5,13 @@ comments. Commands below run from this skill directory, require `gh`, `jq`, Python, and Bash, and only read GitHub. Resolve the connected reviewer's login; do not infer it from examples or repository ownership. +This is generic candidate discovery, not a daily eligibility policy. If the +user's session specifies eligibility labels, a changed head since prior review, +a daily cap, or another selection rule, build that eligible set from current +metadata first. Do not let the legacy selector's own-PR/already-reviewed filters +silently override it: select directly when those filters would discard an +explicitly eligible re-review. User-selected PRs do not need to pass the helper. + 1. Check outstanding replies first when the session includes follow-up: `bash scripts/check_replies.sh --reviewer --days 14`. Reopen each returned thread and inspect its current resolution before diff --git a/.claude/skills/review-pr/tests/test_helpers.py b/.claude/skills/review-pr/tests/test_helpers.py index 0c9db90ee..1c09bcbdd 100644 --- a/.claude/skills/review-pr/tests/test_helpers.py +++ b/.claude/skills/review-pr/tests/test_helpers.py @@ -61,12 +61,6 @@ else: ) - - - - - - def test_select_filters_drafts_wip_and_own_prs(self): prs = [ {"number": i, "title": title, "author": {"login": author}, "isDraft": draft} @@ -230,6 +224,5 @@ else: self.assertNotIn("No unanswered replies found", result.stderr) - if __name__ == "__main__": unittest.main()