[Bugfix] Reject instructions changes on locked native duplex sessions (#6318)

Signed-off-by: ANURAG KANADE <anuragkanade6@gmail.com>
This commit is contained in:
Anurag authored and GitHub committed 2026-08-26 16:50:31 +00:00
1 parent 926e7fbfa2
commit 91dd7fcaec
8 files changed
+309 -7

No files matched your search

@@ -14,6 +14,18 @@ class ServingRuntimeConfigError(ValueError):
self.code = code
def reject_changed_runtime_value(
new_value: object,
current_value: object,
*,
message: str,
code: str,
error_cls: type[ServingRuntimeConfigError] = ServingRuntimeConfigError,
) -> None:
if new_value != current_value:
raise error_cls(message, code=code)
class PcmAppendReservation(Protocol):
operation_id: str
payload: dict[str, object] | None
@@ -64,6 +76,7 @@ class ServingRuntimeSessionState(Protocol):
audio_buffer: PcmAppendBuffer
input_since_commit: bool
speech_since_commit: bool
native_context_locked: bool
committed_audio_payload: dict[str, object] | None
committed_audio_operation_id: str | None
committed_audio_reserved_bytes: int
@@ -1156,6 +1156,18 @@ class OmniDuplexSessionHandler(
) -> dict[str, object] | None:
if not self._uses_native_input_append(session):
return None
if (
candidate_config.instructions != session.config.instructions
and self._runtime_session_state(session).native_context_locked
):
return {
"type": "error",
"session_id": session.session_id,
"code": "instructions_update_unsupported",
"error": "session.update cannot change instructions after the native duplex context is initialized",
}
if session.config.extra_body.get("minicpmo45_native_duplex") is not True:
return None
if not self._config_requests_audio_output(candidate_config):
return None
if "ref_audio_data" in session.runtime_config:
@@ -1326,6 +1338,19 @@ class OmniDuplexSessionHandler(
"code": "ref_audio_update_unsupported",
"error": "session.update cannot change ref_audio after the native duplex runtime is open",
}
extra_body_payload = payload.get("extra_body")
if isinstance(extra_body_payload, dict) and "minicpmo45_native_duplex" in extra_body_payload:
current_native_duplex = session.config.extra_body.get("minicpmo45_native_duplex")
if (
current_native_duplex is not None
and extra_body_payload["minicpmo45_native_duplex"] != current_native_duplex
):
return {
"type": "error",
"session_id": session.session_id,
"code": "native_duplex_mode_update_unsupported",
"error": "session.update cannot change minicpmo45_native_duplex after the session is created",
}
if isinstance(payload.get("instructions"), str):
session.config.instructions = str(payload["instructions"])
elif "instructions" in payload and payload.get("instructions") is None:
@@ -28,6 +28,7 @@ from vllm_omni.experimental.fullduplex.openai.realtime_session import (
)
from vllm_omni.experimental.fullduplex.openai.runtime_adapter import (
PcmAppendReservation,
ServingRuntimeConfigError,
ServingRuntimeSessionState,
payload_turn_id,
)
@@ -357,6 +358,7 @@ class DuplexSessionRunnerMixin:
expected_epoch=append_epoch,
)
if append_ok:
native.native_context_locked = True
if pcm_reservation is not None:
pcm_reservation.commit()
session.release_input_bytes(pcm_reservation.byte_count)
@@ -1072,10 +1074,21 @@ class DuplexSessionRunnerMixin:
if runtime_update_error is not None:
await emit_event(runtime_update_error)
continue
candidate_runtime_config = self._runtime_config_for_session_update(
session,
candidate_config,
)
try:
candidate_runtime_config = self._runtime_config_for_session_update(
session,
candidate_config,
)
except ServingRuntimeConfigError as exc:
await emit_event(
{
"type": "error",
"session_id": session.session_id,
"code": exc.code,
"error": str(exc),
}
)
continue
if not await self._signal_runtime_session(
session,
turn_event,