From 81b9e40bbf53158e24e1721118e69253e64da12e Mon Sep 17 00:00:00 2001 From: tzhouam Date: Tue, 24 Feb 2026 07:56:47 +0000 Subject: [PATCH] Enhance signature compatibility checks in OmniLLM tests - Improved the test_overridden_method_signatures_compatible function to better handle missing parameters in method signatures. - Added logic to account for VAR_KEYWORD parameters, ensuring more accurate detection of signature mismatches. Signed-off-by: [Your Name] Signed-off-by: tzhouam --- tests/entrypoints/test_omni_llm.py | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/entrypoints/test_omni_llm.py b/tests/entrypoints/test_omni_llm.py index b3ad4ce01..b48947434 100644 --- a/tests/entrypoints/test_omni_llm.py +++ b/tests/entrypoints/test_omni_llm.py @@ -1047,9 +1047,22 @@ def test_overridden_method_signatures_compatible(up_mod: str, up_cls: str, omni_ except (ValueError, TypeError): continue - base_params = set(base_sig.parameters.keys()) + omni_has_var_keyword = any(p.kind == inspect.Parameter.VAR_KEYWORD for p in omni_sig.parameters.values()) + + base_params = base_sig.parameters omni_params = set(omni_sig.parameters.keys()) - missing = base_params - omni_params + + missing = [] + for pname, param in base_params.items(): + if pname in omni_params: + continue + if omni_has_var_keyword and param.kind in ( + inspect.Parameter.KEYWORD_ONLY, + inspect.Parameter.POSITIONAL_OR_KEYWORD, + ): + continue + missing.append(pname) + if missing: failures.append(f"{omni_cls}.{name}() missing params {sorted(missing)}; base={base_sig}, omni={omni_sig}")