From 745ef312a73ac7cab594df120ca3b4614f68fe4f Mon Sep 17 00:00:00 2001 From: Daniel Huang Date: Tue, 10 Mar 2026 00:44:54 -0700 Subject: [PATCH] [Enhancement][pytest] Check for process running during start server (#1559) Signed-off-by: Daniel Huang --- tests/conftest.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index c775ae349..619dae3b8 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -1057,15 +1057,16 @@ class OmniServer: max_wait = 1200 # 20 minutes start_time = time.time() while time.time() - start_time < max_wait: - try: - with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock: - sock.settimeout(1) - result = sock.connect_ex((self.host, self.port)) - if result == 0: - print(f"Server ready on {self.host}:{self.port}") - return - except Exception: - pass + # Check for process status + ret = self.proc.poll() + if ret is not None: + raise RuntimeError(f"Server processes exited with code {ret} before becoming ready.") + with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock: + sock.settimeout(1) + result = sock.connect_ex((self.host, self.port)) + if result == 0: + print(f"Server ready on {self.host}:{self.port}") + return time.sleep(2) raise RuntimeError(f"Server failed to start within {max_wait} seconds")