From 677265b64b7870374705f18e81579c9d6e5ec8c7 Mon Sep 17 00:00:00 2001 From: Rahul Steiger Date: Mon, 7 Sep 2026 10:06:16 +0200 Subject: [PATCH] [Bugfix][Diffusion] Make Cosmos3 transfer image arrays writable (#6915) Signed-off-by: Rahul Steiger Co-authored-by: Rahul Steiger Co-authored-by: Rahul Steiger --- .../models/cosmos3/test_cosmos3_pipeline.py | 15 +++++++++++++++ vllm_omni/diffusion/models/cosmos3/transfer.py | 4 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tests/diffusion/models/cosmos3/test_cosmos3_pipeline.py b/tests/diffusion/models/cosmos3/test_cosmos3_pipeline.py index 836e87219..0b2ed3a57 100644 --- a/tests/diffusion/models/cosmos3/test_cosmos3_pipeline.py +++ b/tests/diffusion/models/cosmos3/test_cosmos3_pipeline.py @@ -1180,6 +1180,21 @@ def test_transfer_fps_matches_resolved_frame_rate_precedence() -> None: assert cfg.fps == sp.resolved_frame_rate == 12.0 +@pytest.mark.parametrize("use_path", [False, True], ids=["image", "path"]) +def test_transfer_pil_conversion_returns_writable_array(tmp_path, use_path: bool) -> None: + from vllm_omni.diffusion.models.cosmos3 import transfer + + image = Image.new("RGB", (5, 4), "red") + value = image + if use_path: + value = tmp_path / "control.png" + image.save(value) + + array = transfer._pil_to_uint8_rgb(value) + + assert array.flags.writeable + + def test_transfer_vae_executor_requires_distributed_vae() -> None: from vllm_omni.diffusion.models.cosmos3.pipeline_cosmos3 import Cosmos3OmniDiffusersPipeline diff --git a/vllm_omni/diffusion/models/cosmos3/transfer.py b/vllm_omni/diffusion/models/cosmos3/transfer.py index 9c8a52f3f..65bbbcef8 100644 --- a/vllm_omni/diffusion/models/cosmos3/transfer.py +++ b/vllm_omni/diffusion/models/cosmos3/transfer.py @@ -439,9 +439,9 @@ def uint8_cthw_to_normalized_5d(frames: torch.Tensor, *, dtype: torch.dtype) -> def _pil_to_uint8_rgb(value: Any) -> np.ndarray: if isinstance(value, PIL.Image.Image): - return np.asarray(value.convert("RGB"), dtype=np.uint8) + return np.array(value.convert("RGB"), dtype=np.uint8, copy=True) if isinstance(value, str | Path): - return np.asarray(PIL.Image.open(value).convert("RGB"), dtype=np.uint8) + return np.array(PIL.Image.open(value).convert("RGB"), dtype=np.uint8, copy=True) if isinstance(value, torch.Tensor): tensor = value.detach().cpu() if tensor.ndim == 3 and tensor.shape[0] in (3, 4):