From 58cb8de68bfef2993440b568907db60f448956b6 Mon Sep 17 00:00:00 2001 From: Alex Brooks Date: Mon, 31 Aug 2026 02:13:59 -0600 Subject: [PATCH] [CI] Fix Speech CI Validation Messages (#6827) Signed-off-by: Alex Brooks --- .../invalid_param_test/test_invalid_audio_diffusion.py | 8 ++++++-- .../invalid_param_test/test_invalid_audio_speech.py | 8 +++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/dfx/reliability/invalid_param_test/test_invalid_audio_diffusion.py b/tests/dfx/reliability/invalid_param_test/test_invalid_audio_diffusion.py index 2cc549c5d..f14dcf8c1 100644 --- a/tests/dfx/reliability/invalid_param_test/test_invalid_audio_diffusion.py +++ b/tests/dfx/reliability/invalid_param_test/test_invalid_audio_diffusion.py @@ -70,10 +70,14 @@ _PARAMS = [ pytest.param({"guidance_scale": -1.0}, "guidance_scale", id="guidance_scale_negative", marks=_SKIP_ISSUE_3649), pytest.param({"guidance_scale": 0}, "guidance_scale", id="guidance_scale_zero", marks=_SKIP_ISSUE_3649), pytest.param( - {"num_inference_steps": 0}, "num_inference_steps", id="num_inference_steps_zero", marks=_SKIP_ISSUE_3649 + {"num_inference_steps": 0}, + ("num_inference_steps", "greater than or equal to 1"), + id="num_inference_steps_zero", ), pytest.param( - {"num_inference_steps": -1}, ("number of steps", "non-negative"), id="num_inference_steps_negative" + {"num_inference_steps": -1}, + ("num_inference_steps", "greater than or equal to 1"), + id="num_inference_steps_negative", ), pytest.param( {"num_inference_steps": 6000}, diff --git a/tests/dfx/reliability/invalid_param_test/test_invalid_audio_speech.py b/tests/dfx/reliability/invalid_param_test/test_invalid_audio_speech.py index 3e0f58a90..9861b609e 100644 --- a/tests/dfx/reliability/invalid_param_test/test_invalid_audio_speech.py +++ b/tests/dfx/reliability/invalid_param_test/test_invalid_audio_speech.py @@ -157,7 +157,13 @@ def test_speech_missing_required_fields(omni_server: OmniServer, online_client: "ref_audio": None, "ref_text": None, }, - ("Invalid voice", "vivian"), + # NOTE: This is delegating down the TTS adapter, so the message is both specific + # to the Qwen3TTS adapter and dependent on whether or not the model has any speakers + # (as opposed to having valida speakers, but getting an invalid speaker). it would + # be more ideal to validate that this is landing on `.validate()` on the adapter + # and ensuring that the returned message matches what we would get from calling the + # adapter validate directly. + ("no speakers configured",), id="customvoice_invalid_voice", ), pytest.param(