[BugFix][CI] Address review follow-ups from v0.24.0 rebase (#4709)
Addresses Gaohan123's post-approval review comments on #4709: - pipeline_dreamzero: restore platform-dispatched synchronize() instead of torch.cuda so DreamZero keeps working on non-CUDA hardware (regression of #4399 introduced during the rebase). - omni_scheduler_mixin: drop the VLLM_OMNI_INPUT_WAIT_TIMEOUT_S env-var override; the full-payload input-wait timeout is now a plain constant. - diffusion_worker: implement _DiffusionVllmModelConfig.is_diffusion by mirroring upstream ModelConfig.is_diffusion (dLLM canvas_length check) and document why omni DiT pipelines must not enable dLLM paths. - qwen3_tts: make _embedding_dtype a class attribute on the talker and prompt-embeds builder so __new__-based test stubs inherit it; remove the (duplicated) manual assignments from the preprocess test. - .buildkite: document why the rebase raised per-step timeouts (steps were killed by the old limits, masking real failures; e.g. CustomVoice passes in ~9-15 min but cold runs were killed at 20m). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
This commit is contained in:
1 parent
f11b32a42e
commit
35a423c9bd
8 files changed
+40
-23
No files matched your search
@@ -34,7 +34,6 @@ def _make_minimal_talker(
|
||||
"""
|
||||
model = Qwen3TTSTalkerForConditionalGeneration.__new__(Qwen3TTSTalkerForConditionalGeneration)
|
||||
model.talker_config = SimpleNamespace(codec_pad_id=7, num_code_groups=16)
|
||||
model._embedding_dtype = torch.bfloat16
|
||||
if tts_pad_embed is None:
|
||||
tts_pad_embed = torch.zeros((1, 4), dtype=torch.bfloat16)
|
||||
model._tts_pad_embed = tts_pad_embed
|
||||
@@ -42,7 +41,6 @@ def _make_minimal_talker(
|
||||
def _default_raise(**_kwargs):
|
||||
raise AssertionError("build_prompt_embeds was not stubbed in this test")
|
||||
|
||||
model._embedding_dtype = torch.bfloat16
|
||||
model._prompt_builder = SimpleNamespace(
|
||||
build_prompt_embeds=build_prompt_embeds if build_prompt_embeds is not None else _default_raise,
|
||||
)
|
||||
@@ -83,7 +81,6 @@ def _make_minimal_builder(
|
||||
builder._codec_embed = lambda ids: torch.zeros((*ids.shape, 4), device=ids.device)
|
||||
builder._residual_code_embeddings = lambda: []
|
||||
builder._speaker_encoder = None
|
||||
builder._embedding_dtype = torch.bfloat16
|
||||
builder._tts_pad_embed_buffer = (
|
||||
tts_pad_embed if tts_pad_embed is not None else torch.zeros((1, 4), dtype=torch.bfloat16)
|
||||
)
|
||||
@@ -92,7 +89,6 @@ def _make_minimal_builder(
|
||||
)
|
||||
builder._speaker_cache = None
|
||||
builder._text_tokenizer = None
|
||||
builder._embedding_dtype = torch.bfloat16
|
||||
builder._ref_audio_artifact_cache_max_entries = 256
|
||||
builder._ref_audio_artifact_cache = OrderedDict()
|
||||
builder._resampler_cache = OrderedDict()
|
||||
|
||||
Reference in new issue
Block a user