diff --git a/.github/workflows/pr-reviewer.yml b/.github/workflows/pr-reviewer.yml index a503d3422..5699e74c8 100644 --- a/.github/workflows/pr-reviewer.yml +++ b/.github/workflows/pr-reviewer.yml @@ -1,6 +1,8 @@ name: VLLM-Omni PR Reviewer on: + pull_request: + types: [opened, ready_for_review] issue_comment: types: [created] @@ -14,14 +16,17 @@ jobs: name: Review Pull Request runs-on: ubuntu-latest timeout-minutes: 10 - # Only run when the comment is from a collaborator/owner/member + # Trigger on: + # 1. PR opened or marked ready for review (auto-run, only from same repo) + # 2. Manual @vllm-omni-reviewer comment by members/collaborators if: | - github.event_name == 'issue_comment' && - github.event.issue.pull_request != null && - contains(github.event.comment.body, '@vllm-omni-reviewer') && - (github.event.comment.author_association == 'MEMBER' || - github.event.comment.author_association == 'COLLABORATOR' || - github.event.comment.author_association == 'OWNER') + (github.event_name == 'pull_request' && github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository) || + (github.event_name == 'issue_comment' && + github.event.issue.pull_request != null && + contains(github.event.comment.body, '@vllm-omni-reviewer') && + (github.event.comment.author_association == 'MEMBER' || + github.event.comment.author_association == 'COLLABORATOR' || + github.event.comment.author_association == 'OWNER')) steps: - name: Checkout repository uses: actions/checkout@v4.2.2 diff --git a/vllm_omni/benchmarks/metrics/metrics.py b/vllm_omni/benchmarks/metrics/metrics.py index 83671b713..3258a4ad5 100644 --- a/vllm_omni/benchmarks/metrics/metrics.py +++ b/vllm_omni/benchmarks/metrics/metrics.py @@ -223,8 +223,8 @@ def calculate_metrics( good_completed += 1 if completed == 0: - warnings.formatwarning = ( - lambda msg, category, filename, lineno, line=None: f"{filename}:{lineno}: {category.__name__}: {msg}\n" + warnings.formatwarning = lambda msg, category, filename, lineno, line=None: ( + f"{filename}:{lineno}: {category.__name__}: {msg}\n" ) warnings.warn( "All requests failed. This is likely due to a misconfiguration on the benchmark arguments.", diff --git a/vllm_omni/diffusion/envs.py b/vllm_omni/diffusion/envs.py index dd566b059..a71dc2e8e 100644 --- a/vllm_omni/diffusion/envs.py +++ b/vllm_omni/diffusion/envs.py @@ -20,7 +20,7 @@ environment_variables: dict[str, Callable[[], Any]] = { # used in distributed environment to determine the master address "MASTER_ADDR": lambda: os.getenv("MASTER_ADDR", ""), # used in distributed environment to manually set the communication port - "MASTER_PORT": lambda: (int(os.getenv("MASTER_PORT", "0")) if "MASTER_PORT" in os.environ else None), + "MASTER_PORT": lambda: int(os.getenv("MASTER_PORT", "0")) if "MASTER_PORT" in os.environ else None, # path to cudatoolkit home directory, under which should be bin, include, # and lib directories. "CUDA_HOME": lambda: os.environ.get("CUDA_HOME", None),