vllm-omni/tests/buildkite/test_rocm_dockerfile.py

# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM-Omni project

from pathlib import Path

import pytest

pytestmark = [pytest.mark.core_model, pytest.mark.cpu]

REPO_ROOT = Path(__file__).resolve().parents[2]
AMD_TEMPLATE = REPO_ROOT / ".buildkite/amd/test-template-amd-omni.j2"
AMD_BUILD_SCRIPT = REPO_ROOT / ".buildkite/amd/scripts/build-ci-image.sh"
CUDA_RELEASE_DOCKERFILE = REPO_ROOT / "docker/Dockerfile.cuda"
CUDA_CI_DOCKERFILE = REPO_ROOT / "docker/Dockerfile.ci"
ROCM_DOCKERFILE = REPO_ROOT / "docker/Dockerfile.rocm"
ROCM_DOCKERIGNORE = REPO_ROOT / "docker/Dockerfile.rocm.dockerignore"


def _docker_arg(path: Path, name: str) -> str:
    prefix = f"ARG {name}="
    matches = [
        line.removeprefix(prefix) for line in path.read_text(encoding="utf-8").splitlines() if line.startswith(prefix)
    ]
    assert len(matches) == 1, f"expected one {name} declaration in {path}, found {len(matches)}"
    return matches[0]


def _line_index(lines: list[str], prefix: str) -> int:
    matches = [index for index, line in enumerate(lines) if line.startswith(prefix)]
    assert len(matches) == 1, f"expected one line starting with {prefix!r}, found {len(matches)}"
    return matches[0]


def test_rocm_base_tracks_cuda_vllm_release() -> None:
    cuda_base = _docker_arg(CUDA_RELEASE_DOCKERFILE, "BASE_IMAGE")
    cuda_image, _, cuda_release = cuda_base.rpartition(":")
    rocm_base = _docker_arg(ROCM_DOCKERFILE, "BASE_IMAGE")

    image_ref, separator, image_tag = rocm_base.rpartition(":")
    assert separator, f"expected a tagged ROCm base image, got {rocm_base}"
    assert cuda_image == "vllm/vllm-openai"
    assert image_ref == "vllm/vllm-openai-rocm"
    assert image_tag == cuda_release == f"v{_docker_arg(CUDA_CI_DOCKERFILE, 'VLLM_VERSION')}"
    assert _docker_arg(CUDA_CI_DOCKERFILE, "VLLM_BASE_IMAGE") == cuda_image
    assert _docker_arg(CUDA_CI_DOCKERFILE, "VLLM_BASE_TAG") == "v${VLLM_VERSION}"


def test_rocm_defaults_to_prebuilt_base_image() -> None:
    assert _docker_arg(ROCM_DOCKERFILE, "USE_NIGHTLY_BUILD") == "0"


def test_amd_build_uses_registry_cache() -> None:
    template = AMD_TEMPLATE.read_text(encoding="utf-8")
    script_command = '"bash .buildkite/amd/scripts/build-ci-image.sh"'
    script = AMD_BUILD_SCRIPT.read_text(encoding="utf-8")

    assert template.count(script_command) == 1
    assert "docker buildx build --push" in script
    assert '--cache-from "type=registry,ref=${CACHE_REF}"' in script
    assert '--cache-to "type=registry,ref=${CACHE_REF}' in script
    assert "mode=max" in script


def test_amd_cache_key_tracks_dependency_inputs_and_architecture() -> None:
    script = AMD_BUILD_SCRIPT.read_text(encoding="utf-8")

    for cache_input in (
        "docker/Dockerfile.rocm",
        "${DOCKERFILE}.dockerignore",
        "pyproject.toml",
        "setup.py",
        "requirements",
        "tools/install_torchcodec_rocm.sh",
        "ROCM_ARCH",
    ):
        assert cache_input in script


def test_amd_build_uses_rocm_dockerfile_defaults() -> None:
    build_script = AMD_BUILD_SCRIPT.read_text(encoding="utf-8")

    assert 'DOCKERFILE="docker/Dockerfile.rocm"' in build_script
    for arg_name in ("BASE_IMAGE", "USE_NIGHTLY_BUILD"):
        assert f"--build-arg {arg_name}" not in build_script
        assert f"--build-arg={arg_name}" not in build_script


def test_rocm_source_copy_preserves_dependency_cache() -> None:
    dockerfile = ROCM_DOCKERFILE.read_text(encoding="utf-8")
    lines = dockerfile.splitlines()
    source_copy_index = _line_index(lines, "COPY --link . .")
    test_stage_index = _line_index(lines, "FROM base AS test")

    assert "FROM deps AS base" in lines[:source_copy_index]
    assert any('-e ".[dev]"' in line for line in lines[:source_copy_index])
    assert not any(
        line.startswith(("RUN ", "COPY ", "ADD ")) for line in lines[source_copy_index + 1 : test_stage_index]
    )


def test_rocm_build_context_excludes_git_history() -> None:
    patterns = {
        line.strip()
        for line in ROCM_DOCKERIGNORE.read_text(encoding="utf-8").splitlines()
        if line.strip() and not line.lstrip().startswith("#")
    }

    assert ".git" in patterns


def test_rocm_source_ref_tracks_cuda_vllm_release() -> None:
    cuda_release = _docker_arg(CUDA_CI_DOCKERFILE, "VLLM_VERSION")
    rocm_source_ref = _docker_arg(ROCM_DOCKERFILE, "VLLM_VERSION_OR_COMMIT_HASH")

    assert rocm_source_ref == f"v{cuda_release}"


def test_rocm_dockerfile_contains_vllm_api_canary() -> None:
    dockerfile = ROCM_DOCKERFILE.read_text(encoding="utf-8")
    lines = dockerfile.splitlines()
    nightly_start = _line_index(lines, 'RUN if [ "${USE_NIGHTLY_BUILD}" = "1" ]; then')
    canary = (
        'RUN python3 -c "import vllm; '
        "from vllm.v1.kv_cache_interface import compute_layout_strides; "
        "from vllm.v1.kv_cache_layout import KVCacheLayout;"
    )
    canary_index = _line_index(lines, canary)

    assert any(line.strip() == "fi" for line in lines[nightly_start + 1 : canary_index]), (
        "vLLM API canary must follow the optional nightly source reinstall block"
    )