Publish planner and implementer role guidance v0.2.0
This commit is contained in:
1 parent
370416b87b
commit
370ebd572f
9 files changed
+95
-10
No files matched your search
+31
-2
@@ -13,13 +13,42 @@ ROOT = Path(__file__).resolve().parents[1]
|
||||
|
||||
class PackageTests(unittest.TestCase):
|
||||
def test_release_package_and_starter_are_valid(self):
|
||||
for path in (ROOT / "packages/planner-scope", ROOT / "examples/starter-planner"):
|
||||
for path in (ROOT / "packages/planner-scope", ROOT / "packages/implementer-handoff", ROOT / "examples/starter-planner"):
|
||||
check_package(path)
|
||||
with tempfile.TemporaryDirectory() as directory:
|
||||
first = package_archive(path, Path(directory) / "one.zip")
|
||||
second = package_archive(path, Path(directory) / "two.zip")
|
||||
self.assertEqual(first, second)
|
||||
|
||||
def test_maintained_guidance_covers_distinct_role_steps(self):
|
||||
expected = {
|
||||
"planner-scope": ("planner", "planning", "scope.md", "Plan"),
|
||||
"implementer-handoff": ("implementer", "implementation", "handoff.md", "documentation"),
|
||||
}
|
||||
for name, (role, step, resource, marker) in expected.items():
|
||||
with self.subTest(name=name):
|
||||
package = ROOT / "packages" / name
|
||||
manifest = json.loads((package / "relayview-skill.json").read_text())
|
||||
self.assertEqual((manifest["role"], manifest["step"]), (role, step))
|
||||
self.assertEqual(manifest["source"], {"kind": "first-party", "reference": "v0.2.0"})
|
||||
self.assertIn(resource, [item["path"] for item in manifest["files"]])
|
||||
self.assertIn(marker, (package / "SKILL.md").read_text() + (package / resource).read_text())
|
||||
|
||||
def test_user_fork_is_distinct_under_same_role_limits(self):
|
||||
with tempfile.TemporaryDirectory() as directory:
|
||||
package = Path(directory) / "implementer-handoff"
|
||||
shutil.copytree(ROOT / "packages/implementer-handoff", package)
|
||||
original = check_package(package)
|
||||
resource = package / "handoff.md"
|
||||
resource.write_text(resource.read_text() + "\n- Prefer the team's concise PR summary format.\n")
|
||||
manifest_path = package / "relayview-skill.json"
|
||||
manifest = json.loads(manifest_path.read_text())
|
||||
manifest["source"] = {"kind": "user", "reference": "team-fork-1"}
|
||||
next(item for item in manifest["files"] if item["path"] == "handoff.md")["sha256"] = hashlib.sha256(resource.read_bytes()).hexdigest()
|
||||
manifest_path.write_text(json.dumps(manifest))
|
||||
self.assertNotEqual(check_package(package), original)
|
||||
self.assertEqual((manifest["role"], manifest["step"]), ("implementer", "implementation"))
|
||||
|
||||
def test_rejects_scripts_and_undeclared_files(self):
|
||||
with tempfile.TemporaryDirectory() as directory:
|
||||
package = Path(directory) / "planner-scope"
|
||||
@@ -74,7 +103,7 @@ class PackageTests(unittest.TestCase):
|
||||
def test_rejects_owner_incompatible_frontmatter_values(self):
|
||||
for old, new in (
|
||||
("metadata:\n", "disable-model-invocation: yes\nmetadata:\n"),
|
||||
("description: Check a Planner's issue scope and evidence before drafting a Plan.", "description: "),
|
||||
("description: Check assigned issue scope, neighboring work, and verification before drafting a Plan.", "description: "),
|
||||
):
|
||||
with self.subTest(new=new), tempfile.TemporaryDirectory() as directory:
|
||||
package = Path(directory) / "planner-scope"
|
||||
|
||||
Reference in new issue
Block a user