From 1f6cce14a864db8e3b2c9b9e1641774299b8d737 Mon Sep 17 00:00:00 2001 From: Kyle Merritt Date: Fri, 13 Nov 2026 17:30:35 -0500 Subject: [PATCH] Extract optional automatic Reviewer finding presentation --- README.md | 2 ++ packages/code-review-auto/SKILL.md | 11 +++++++++++ packages/code-review-auto/relayview-skill.json | 15 +++++++++++++++ packages/code-review/SKILL.md | 4 +++- packages/code-review/relayview-skill.json | 4 ++-- tests/test_packages.py | 8 ++++++++ 6 files changed, 41 insertions(+), 3 deletions(-) create mode 100644 packages/code-review-auto/SKILL.md create mode 100644 packages/code-review-auto/relayview-skill.json diff --git a/README.md b/README.md index 32caed0..14083f2 100644 --- a/README.md +++ b/README.md @@ -87,3 +87,5 @@ Judge a change over several runs, using the tool calls each run made, not one su A release tag pins public source. CI runs package checks and archives from that source. RelayView's bundled copy records the source tag and commit plus each package identity and file hash, then verifies the bytes in its own focused test. A bundled update creates a new release identity; it does not overwrite a user fork. The MIT license covers this repository only. The contribution policy is in [CONTRIBUTING.md](CONTRIBUTING.md); dependency notices are in [NOTICE.md](NOTICE.md). + +The automatic `code-review-auto` package supplies optional bounded, path-aware finding presentation. Broader two-axis standards/spec inspection remains in the manual `code-review` package. Both use only the assigned Reviewer capabilities; required adequacy, disposition and recovery stay with the owner. diff --git a/packages/code-review-auto/SKILL.md b/packages/code-review-auto/SKILL.md new file mode 100644 index 0000000..02dc2ff --- /dev/null +++ b/packages/code-review-auto/SKILL.md @@ -0,0 +1,11 @@ +--- +name: code-review-auto +description: Present findings for the owner-assigned review candidate. +metadata: + relayview-display-name: Review finding presentation + relayview-version: 0.10.0 +--- + +# Review finding presentation + +Keep findings bounded, path-aware, and actionable. diff --git a/packages/code-review-auto/relayview-skill.json b/packages/code-review-auto/relayview-skill.json new file mode 100644 index 0000000..ce4f0c3 --- /dev/null +++ b/packages/code-review-auto/relayview-skill.json @@ -0,0 +1,15 @@ +{ + "schemaVersion": 1, + "source": { + "kind": "first-party", + "reference": "v0.10.0" + }, + "role": "reviewer", + "step": "review", + "files": [ + { + "path": "SKILL.md", + "sha256": "5a09004af9e208a80712dba2dad2975fcd457f296472f8cd2e13f48b43d0950d" + } + ] +} diff --git a/packages/code-review/SKILL.md b/packages/code-review/SKILL.md index 8c197f1..bf9e116 100644 --- a/packages/code-review/SKILL.md +++ b/packages/code-review/SKILL.md @@ -4,7 +4,7 @@ description: Review the owner-pinned candidate against repository standards and disable-model-invocation: true metadata: relayview-display-name: Code review - relayview-version: 0.3.0 + relayview-version: 0.10.0 --- # Two-axis code review @@ -12,3 +12,5 @@ metadata: Review only the candidate and commit identity supplied by the owner. Keep standards and Plan fidelity separate. For standards, cite the exact repository rule and changed hunk; identify possible design smells as judgment calls, never as rule violations. A documented local standard takes precedence over a general heuristic. For Plan fidelity, identify missing or partial requirements, unrequested behavior, and behavior whose implementation contradicts the accepted Plan. Cite the Plan clause and code evidence for each finding. Report both axes even if one has no findings. Distinguish evidence, inference, and uncertainty; skip issues already enforced by tooling unless the enforcement itself failed. Do not edit the candidate, create subagents, choose a new base, change the acceptance state, or request a new review run. The owner controls review scheduling, exact-head binding, and the response to findings. + +Keep findings bounded, path-aware, and actionable. diff --git a/packages/code-review/relayview-skill.json b/packages/code-review/relayview-skill.json index 749ec5e..f4eaa49 100644 --- a/packages/code-review/relayview-skill.json +++ b/packages/code-review/relayview-skill.json @@ -2,14 +2,14 @@ "schemaVersion": 1, "source": { "kind": "first-party", - "reference": "v0.3.0" + "reference": "v0.10.0" }, "role": "reviewer", "step": "review", "files": [ { "path": "SKILL.md", - "sha256": "c2b05163e738e59573b96f723d5340f56304299bcdf251e38b2d2afb4eda2b5a" + "sha256": "bb7e5e4d30dcf43eddb9e16ddf7e7ddad123fba18ef7b22286b8b1233888b81b" } ] } diff --git a/tests/test_packages.py b/tests/test_packages.py index 582fb6e..1bc2aa4 100644 --- a/tests/test_packages.py +++ b/tests/test_packages.py @@ -12,6 +12,14 @@ ROOT = Path(__file__).resolve().parents[1] class PackageTests(unittest.TestCase): + def test_automatic_review_is_only_extracted_presentation(self): + package = ROOT / "packages/code-review-auto" + check_package(package) + text = (package / "SKILL.md").read_text() + self.assertIn("path-aware, and actionable", text) + self.assertNotIn("Report both axes", text) + self.assertNotIn("subagent", text) + def test_handoff_clarification_method(self): package = ROOT / "packages/implementer-handoff" check_package(package)