Add role-local migrated skill guidance

tests/test_packages.py

@@ -12,8 +12,31 @@ ROOT = Path(__file__).resolve().parents[1]
 
 
 class PackageTests(unittest.TestCase):
+    def test_migrated_role_guidance_has_one_declared_role_step(self):
+        expected = {"codebase-design": ("planner", "planning"), "grill-me": ("planner", "planning"),
+                    "grilling": ("planner", "planning"), "to-questionnaire": ("planner", "planning"),
+                    "diagnosing-bugs": ("implementer", "implementation"),
+                    "domain-modeling": ("implementer", "implementation"),
+                    "migrate-to-shoehorn": ("implementer", "implementation"),
+                    "pr": ("implementer", "implementation"), "prototype": ("implementer", "implementation"),
+                    "scaffold-exercises": ("implementer", "implementation"),
+                    "shared-abstraction-refactor": ("implementer", "implementation"),
+                    "split-large-files": ("implementer", "implementation"),
+                    "tdd": ("implementer", "implementation"),
+                    "writing-for-agents": ("implementer", "implementation"),
+                    "code-review": ("reviewer", "review"),
+                    "c4-diff": ("reviewer", "review"),
+                    "research": ("planner", "planning"),
+                    "improve-codebase-architecture": ("planner", "planning")}
+        for name, role_step in expected.items():
+            with self.subTest(name=name):
+                package = ROOT / "packages" / name
+                manifest = json.loads((package / "relayview-skill.json").read_text())
+                self.assertEqual((manifest["role"], manifest["step"]), role_step)
+                check_package(package)
+
     def test_release_package_and_starter_are_valid(self):
-        for path in (ROOT / "packages/planner-scope", ROOT / "packages/implementer-handoff", ROOT / "examples/starter-planner"):
+        for path in sorted((ROOT / "packages").iterdir()) + [ROOT / "examples/starter-planner"]:
             check_package(path)
             with tempfile.TemporaryDirectory() as directory:
                 first = package_archive(path, Path(directory) / "one.zip")